AAE-28530 Fix teams notif status detection #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old action checks completed jobs status: sometimes we notify while there's only one job and none completed, sometimes the job is not completed but there's a failed step. Modified the jq command to check ".jobs[].steps[]" status instead of ".jobs[]"
gionn
reviewed
Dec 18, 2024
This reverts commit 6ee38cb.
dsibilio
reviewed
Dec 18, 2024
Co-authored-by: Domenico Sibilio <[email protected]>
gionn
approved these changes
Dec 18, 2024
dsibilio
approved these changes
Dec 18, 2024
atchertchian
deleted the
improvement/AAE-28530-teams-notifications-fix-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old action checks completed jobs status: sometimes we notify while there's only one job and none completed, sometimes the job is not completed but there's a failed step.
Modified the jq command to check ".jobs[].steps[]" status instead of ".jobs[]"
Checklist
Description